Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2-10-test] Avoid grouping task instance stats by try_number for dynamic mapped tasks (#44300) #44319

Merged
merged 2 commits into from
Nov 24, 2024
Merged

[v2-10-test] Avoid grouping task instance stats by try_number for dynamic mapped tasks (#44300) #44319

merged 2 commits into from
Nov 24, 2024
+58 −2

Conversation

github-actions[bot]
Copy link

(cherry picked from commit 5e52bd2)

Co-authored-by: Shahar Epstein 60007259+shahar1@users.noreply.github.com

@shahar1
[v2-10-test] Avoid grouping task instance stats by try_number for dyn…
1a320dd 
…amic mapped tasks (#44300)

(cherry picked from commit 5e52bd2)

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Nov 24, 2024
@github-actions github-actions bot mentioned this pull request Nov 24, 2024
Merged
@potiuk potiuk closed this Nov 24, 2024
@potiuk potiuk reopened this Nov 24, 2024
@shahar1
Copy link
Contributor

shahar1 commented Nov 24, 2024 •
edited
Loading

  1. The unit test fails, I'll take care of it.
  2. @potiuk What do you think that we should do with back-ported newsfragments?
    Should we keep them with the original PR id, or change it to the backport's? It could be automated as part of the cherry-picker, I wonder if it's worth the effort :)

Update: I just checked and it seems that we don't have many back-ported news fragments.

@jscheffl jscheffl added this to the Airflow 2.10.4 milestone Nov 24, 2024
@potiuk
Copy link
Member

potiuk commented Nov 24, 2024

Should we keep them with the original PR id, or change it to the backport's? It could be automated as part of the cherry-picker, I wonder if it's worth the effort :)

Should be original PR.

Update: I just checked and it seems that we don't have many back-ported news fragments.

Yes - they are deleted after they are incorporated by release manager in release notes for 2.10.1* when they are relased - this is part of towncrier workflow. We should also then delete the newsfragment from main I guess (@jedcunningham ? @ephraimbuddy @utkarsharma2 ) because otherwise the newsfragment will appear in two releases. I think it is automated by our workflow and one reason why newsfragments should be committed in their corresponding PR because "cherry-picking" PR means also "cherry-picking" release notes.

@potiuk
Copy link
Member

potiuk commented Nov 24, 2024

So I am not sure if the rename was a good idea. :)

@shahar1 shahar1 force-pushed the backport-5e52bd2-v2-10-test branch from 47d9314 to 0afad07 Compare November 24, 2024 10:26
@shahar1
Copy link
Contributor

shahar1 commented Nov 24, 2024

Should we keep them with the original PR id, or change it to the backport's? It could be automated as part of the cherry-picker, I wonder if it's worth the effort :)

Should be original PR.

Update: I just checked and it seems that we don't have many back-ported news fragments.

Yes - they are deleted after they are incorporated by release manager in release notes for 2.10.1* when they are relased - this is part of towncrier workflow. We should also then delete the newsfragment from main I guess (@jedcunningham ? @ephraimbuddy @utkarsharma2 ) because otherwise the newsfragment will appear in two releases. I think it is automated by our workflow and one reason why newsfragments should be committed in their corresponding PR because "cherry-picking" PR means also "cherry-picking" release notes.

Thanks for the info :)

So I am not sure if the rename was a good idea. :)

Dropped last commit

@potiuk potiuk merged commit a361291 into v2-10-test Nov 24, 2024
94 checks passed
@shahar1 shahar1 deleted the backport-5e52bd2-v2-10-test branch November 24, 2024 11:41
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Dec 4, 2024
utkarsharma2 pushed a commit that referenced this pull request Dec 4, 2024
@github-actions @shahar1 @utkarsharma2
[v2-10-test] Avoid grouping task instance stats by try_number for dyn…
fff2fa6 
…amic mapped tasks (#44300) (#44319)

* [v2-10-test] Avoid grouping task instance stats by try_number for dynamic mapped tasks (#44300)
(cherry picked from commit 5e52bd2)

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

* Update test_views_grid.py

---------

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
utkarsharma2 pushed a commit that referenced this pull request Dec 9, 2024
@github-actions @shahar1 @utkarsharma2
[v2-10-test] Avoid grouping task instance stats by try_number for dyn…
47a5092 
…amic mapped tasks (#44300) (#44319)

* [v2-10-test] Avoid grouping task instance stats by try_number for dynamic mapped tasks (#44300)
(cherry picked from commit 5e52bd2)

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

* Update test_views_grid.py

---------

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2 utkarsharma2 mentioned this pull request Dec 10, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

Assignees
No one assigned
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@shahar1 @potiuk @utkarsharma2 @jscheffl